cloud-fan commented on code in PR #36150:
URL: https://github.com/apache/spark/pull/36150#discussion_r891408643
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -736,6 +737,24 @@ abstract class TypeCoercionBase {
}
}
+ /**
+ * Determines the value type of a [[Melt]].
+ */
+ object MeltCoercion extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan =
+ plan resolveOperators {
+ case m: Melt if m.values.nonEmpty && m.values.forall(_.resolved) &&
m.valueType.isEmpty =>
Review Comment:
A more common way is to add cast to value expressions to make them the same
type. e.g.
```
case m: Melt if m.values.nonEmpty && !haveSameType(m.values.map(_.dataType))
=> {
val commonType = ...
if (commonType.isDefined) {
m.copy(values = values.map(Cast(_, commonType.get)))
} else {
fail...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
