cloud-fan commented on code in PR #36150:
URL: https://github.com/apache/spark/pull/36150#discussion_r892459971
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -736,6 +737,24 @@ abstract class TypeCoercionBase {
}
}
+ /**
+ * Determines the value type of a [[Melt]].
+ */
+ object MeltCoercion extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan =
+ plan resolveOperators {
+ case m: Melt if m.values.nonEmpty && m.values.forall(_.resolved) &&
m.valueType.isEmpty =>
Review Comment:
> You are saying it is preferred to move this into TypeCoercion?
Yea, that's how other type coercion rules are doing.
> If the rule returns an unchanged Melt, will this rule be called again?
It will and it doesn't matter. The catalyst framework runs a batch of rules
again and again, until the query plan stops changing (reaching fixed point)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
