LuciferYang commented on code in PR #36900:
URL: https://github.com/apache/spark/pull/36900#discussion_r899916743
##########
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java:
##########
@@ -306,7 +306,7 @@ public long maxChunksBeingTransferred() {
* ceiling of the nearest integer.
*/
public int chunkFetchHandlerThreads() {
- if (!this.getModuleName().equalsIgnoreCase("shuffle")) {
+ if (!"shuffle".equalsIgnoreCase(this.getModuleName())) {
Review Comment:
https://github.com/apache/spark/blob/75b396505a266e839b9e2dc1d3ec36eebb6deb43/common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java#L51-L55
Maybe we should change line 55 to `this.module =
Objects.requireNonNull(module);` to ensure `this.module` is not null,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
