LuciferYang commented on code in PR #36900:
URL: https://github.com/apache/spark/pull/36900#discussion_r899930383
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java:
##########
@@ -282,8 +282,8 @@ private String getIpAddress() {
String clientIpAddress;
// Http transport mode.
// We set the thread local ip address, in ThriftHttpServlet.
- if (cliService.getHiveConf().getVar(
- ConfVars.HIVE_SERVER2_TRANSPORT_MODE).equalsIgnoreCase("http")) {
+ if ("http".equalsIgnoreCase(cliService.getHiveConf().getVar(
Review Comment:
This file copy from `hive`, It's best not to touch it to avoid conflict
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java:
##########
@@ -282,8 +282,8 @@ private String getIpAddress() {
String clientIpAddress;
// Http transport mode.
// We set the thread local ip address, in ThriftHttpServlet.
- if (cliService.getHiveConf().getVar(
- ConfVars.HIVE_SERVER2_TRANSPORT_MODE).equalsIgnoreCase("http")) {
+ if ("http".equalsIgnoreCase(cliService.getHiveConf().getVar(
Review Comment:
This file copy from `hive`, I think it's best not to touch it to avoid
conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
