dongjoon-hyun commented on code in PR #36900:
URL: https://github.com/apache/spark/pull/36900#discussion_r900530677
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java:
##########
@@ -394,7 +394,7 @@ private class ManagedBufferIterator implements
Iterator<ManagedBuffer> {
size = reduceIdAndChunkIds.length;
blockDataForIndexFn = index ->
mergeManager.getMergedBlockData(msg.appId, shuffleId,
shuffleMergeId, reduceIdAndChunkIds[index],
reduceIdAndChunkIds[index + 1]);
- } else if (blockId0Parts.length == 3 && blockId0Parts[0].equals("rdd")) {
+ } else if (blockId0Parts.length == 3 && "rdd".equals(blockId0Parts[0])) {
Review Comment:
Unfortunately, it doesn't looks like this code has any improvement like you
claimed, @dcoliversun .
If `blockID0Parts[0] == null`, it fails already at line 383 before reaches
this line 397.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
