dongjoon-hyun commented on code in PR #36900:
URL: https://github.com/apache/spark/pull/36900#discussion_r900531182
##########
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java:
##########
@@ -123,8 +123,7 @@ public TransportContext(
this.rpcHandler = rpcHandler;
this.closeIdleConnections = closeIdleConnections;
- if (conf.getModuleName() != null &&
- conf.getModuleName().equalsIgnoreCase("shuffle") &&
+ if ("shuffle".equalsIgnoreCase(conf.getModuleName()) &&
Review Comment:
Previously, there is no NPE in this case. So, this is just a
code-implication instead of avoiding any NPE.
In other words, this contribution is unmatched with the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
