cloud-fan commented on code in PR #36593:
URL: https://github.com/apache/spark/pull/36593#discussion_r907996644
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -283,6 +285,16 @@ class V2ExpressionBuilder(e: Expression, isPredicate:
Boolean = false) {
None
}
// TODO supports other expressions
+ case ApplyFunctionExpression(function, children) =>
+ val childrenExpressions = children.flatMap(generateExpression(_))
+ if (childrenExpressions.length == children.length) {
+ Some(new UserDefinedScalarFunc(
+ function.name().toUpperCase(Locale.ROOT),
+ function.canonicalName().toUpperCase(Locale.ROOT),
Review Comment:
let's keep the names as it is, do not upper case them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
