cloud-fan commented on code in PR #36593:
URL: https://github.com/apache/spark/pull/36593#discussion_r910236213
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -39,6 +46,75 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession
with ExplainSuiteHel
val url =
s"jdbc:h2:${tempDir.getCanonicalPath};user=testUser;password=testPass"
var conn: java.sql.Connection = null
+ val testH2Dialect = new JdbcDialect {
+ override def canHandle(url: String): Boolean = H2Dialect.canHandle(url)
+
+ class H2SQLBuilder extends JDBCSQLBuilder {
+ override def visitUserDefinedScalarFunction(
+ funcName: String, canonicalName: String, inputs: Array[String]):
String = {
+ canonicalName match {
+ case "h2.char_length" =>
+ s"$funcName(${inputs.mkString(", ")})"
+ case _ => super.visitUserDefinedScalarFunction(funcName,
canonicalName, inputs)
+ }
+ }
+
+ override def visitUserDefinedAggregateFunction(
+ funcName: String,
+ canonicalName: String,
+ isDistinct: Boolean,
+ inputs: Array[String]): String = {
+ canonicalName match {
+ case "h2.iavg" =>
+ if (isDistinct) {
+ s"$funcName(DISTINCT ${inputs.mkString(", ")})"
+ } else {
+ s"$funcName(${inputs.mkString(", ")})"
+ }
+ case _ =>
+ super.visitUserDefinedAggregateFunction(funcName, canonicalName,
isDistinct, inputs)
+ }
+ }
+ }
+
+ override def compileExpression(expr: Expression): Option[String] = {
+ val h2SQLBuilder = new H2SQLBuilder()
+ try {
+ Some(h2SQLBuilder.build(expr))
+ } catch {
+ case NonFatal(e) =>
+ logWarning("Error occurs while compiling V2 expression", e)
+ None
+ }
+ }
+
+ override def compileAggregate(aggFunction: AggregateFunc): Option[String]
= {
+ super.compileAggregate(aggFunction).orElse(
+ aggFunction match {
+ case f: UserDefinedAggregateFunc if f.name() == "iavg" =>
+ assert(f.children().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ compileExpression(f.children().head).map(v => s"AVG($distinct$v)")
+ case _ => None
+ }
+ )
+ }
+
+ override def functions: Seq[(String, UnboundFunction)] =
H2Dialect.functions
+ }
+
+ case object CharLength extends ScalarFunction[Int] {
+ override def inputTypes(): Array[DataType] = Array(StringType)
+ override def resultType(): DataType = IntegerType
+ override def name(): String = "char_length"
Review Comment:
nit: to be more SQL-ish we can upper case the function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
