LuciferYang commented on code in PR #37029:
URL: https://github.com/apache/spark/pull/37029#discussion_r910643105
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReaderSuite.scala:
##########
@@ -83,10 +80,9 @@ class OrcColumnarBatchReaderSuite extends QueryTest with
SharedSparkSession {
assert(batch.numCols() === 2)
assert(batch.column(0).isInstanceOf[OrcColumnVector])
- assert(batch.column(1).isInstanceOf[OnHeapColumnVector])
+ assert(batch.column(1).isInstanceOf[ConstantColumnVector])
- val p1 = batch.column(1).asInstanceOf[OnHeapColumnVector]
- assert(isConstant.get(p1).asInstanceOf[Boolean]) // Partition column is
constant.
Review Comment:
This assertion is not required when using `ConstantColumnVector`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
