sunchao commented on code in PR #37029:
URL: https://github.com/apache/spark/pull/37029#discussion_r911653363
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java:
##########
@@ -168,9 +169,8 @@ public void initBatch(
for (int i = 0; i < requiredFields.length; i++) {
DataType dt = requiredFields[i].dataType();
if (requestedPartitionColIds[i] != -1) {
- OnHeapColumnVector partitionCol = new OnHeapColumnVector(capacity, dt);
+ ConstantColumnVector partitionCol = new ConstantColumnVector(capacity,
dt);
ColumnVectorUtils.populate(partitionCol, partitionValues,
requestedPartitionColIds[i]);
Review Comment:
after this PR do we still need the other `populate` method on
`WritableColumnVector`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
