amaliujia commented on code in PR #37241:
URL: https://github.com/apache/spark/pull/37241#discussion_r925976129
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -120,7 +120,13 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
val plan = ShowTables(UnresolvedNamespace(ident), None)
val ret = sparkSession.sessionState.executePlan(plan).toRdd.collect()
val tables = ret
- .map(row => ident ++ Seq(row.getString(1)))
+ .map(row =>
+ // for views, their namespace are empty
+ if (row.getString(0).isEmpty) {
+ Seq(row.getString(1))
+ } else {
+ ident ++ Seq(row.getString(1))
+ })
Review Comment:
Maybe it is hard to define whether this is a regression (I would rather say
it is a side effect that given we introduced a way to control current catalog).
I think at least it still maintains backwards compatibility. For old users who
do not need set current catalog, it will still be the one that they would
target to `spark_catalog`. The existing UT has tested that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
