dongjoon-hyun commented on code in PR #37241:
URL: https://github.com/apache/spark/pull/37241#discussion_r926091316
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -120,7 +120,13 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
val plan = ShowTables(UnresolvedNamespace(ident), None)
val ret = sparkSession.sessionState.executePlan(plan).toRdd.collect()
val tables = ret
- .map(row => ident ++ Seq(row.getString(1)))
+ .map(row =>
+ // for views, their namespace are empty
+ if (row.getString(0).isEmpty) {
+ Seq(row.getString(1))
+ } else {
+ ident ++ Seq(row.getString(1))
+ })
Review Comment:
Thanks for the detail. Yes, it's hard to say always during extending the
existing semantics. New features are always nice to have, but what I hope is to
keep the original features safe and independent as much as possible . As long
as the old code works, we are good. Thank you again for all your efforts,
@amaliujia .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
