MaxGekk commented on code in PR #37357:
URL: https://github.com/apache/spark/pull/37357#discussion_r934757793


##########
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##########
@@ -318,6 +319,15 @@ abstract class SparkFunSuite
     } else {
       assert(expectedParameters === parameters)
     }
+    val actualQueryContext = exception.getQueryContext()
+    assert(actualQueryContext.length === queryContext.length, "Invalid length 
of the query context")
+    actualQueryContext.zip(queryContext).foreach { case (actual, expected) =>

Review Comment:
   why? I know exactly which field is invalid in my implementation. In your 
case, I will only know that contexts are different and then I will have to 
compare fields by eyes.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to