MaxGekk commented on code in PR #37357:
URL: https://github.com/apache/spark/pull/37357#discussion_r934755593
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryErrorsSuiteBase.scala:
##########
@@ -51,4 +51,17 @@ trait QueryErrorsSuiteBase extends SharedSparkSession {
assert(exception.getSqlState === sqlState)
assert(exception.getMessage === s"""\n[$fullErrorClass] """ + message)
}
+
+ case class ExpectedContext(
Review Comment:
For simplicity, `ExpectedContext` contains only import info provided via
`QueryContext`. For instance, SQLQueryContext contains entire SQL text NOT
fragment. Why should we check entire SQL statements in tests? I do believe that
we should check only values exposed via public API, and do not check internal
staff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
