peter-toth commented on code in PR #37334:
URL: https://github.com/apache/spark/pull/37334#discussion_r934851490


##########
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q70.sf100/explain.txt:
##########
@@ -157,121 +158,125 @@ Input [2]: [s_state#14, sum#16]
 Keys [1]: [s_state#14]
 Functions [1]: [sum(UnscaledValue(ss_net_profit#10))]
 Aggregate Attributes [1]: [sum(UnscaledValue(ss_net_profit#10))#17]
-Results [3]: [s_state#14, s_state#14, 
MakeDecimal(sum(UnscaledValue(ss_net_profit#10))#17,17,2) AS _w2#18]
+Results [3]: [s_state#14 AS s_state#18, s_state#14, 
MakeDecimal(sum(UnscaledValue(ss_net_profit#10))#17,17,2) AS _w2#19]
 
-(25) Sort [codegen id : 5]
-Input [3]: [s_state#14, s_state#14, _w2#18]
-Arguments: [s_state#14 ASC NULLS FIRST, _w2#18 DESC NULLS LAST], false, 0
+(25) Exchange

Review Comment:
   I put the WIP flag into the PR description for now and giving a try to an 
experiment with 
https://github.com/apache/spark/pull/37334/commits/b3b7d24b47c9748e6cff9211f6576048ba07cc8c
 to fix `AliasAwareOutputPartitioning` and `AliasAwareOutputOrdering` to handle 
cases when `AliasAwareOutputExpression.outputExpressions` contains both an 
attribute and its aliased version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to