peter-toth commented on code in PR #37334:
URL: https://github.com/apache/spark/pull/37334#discussion_r935751761
##########
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala:
##########
@@ -681,7 +681,7 @@ class ExplainSuiteAE extends ExplainSuiteHelper with
EnableAdaptiveExecutionSuit
df.createTempView("df")
val sqlText = "EXPLAIN CODEGEN SELECT key, MAX(value) FROM df GROUP BY
key"
- val expectedCodegenText = "Found 2 WholeStageCodegen subtrees."
+ val expectedCodegenText = "Found 1 WholeStageCodegen subtrees."
Review Comment:
Due to the `AliasAwareOutputPartitioning` fix the explain codegen output
(plan) changed from:
```
Found 2 WholeStageCodegen subtrees.
== Subtree 1 / 2 (maxMethodCodeSize:282; maxConstantPoolSize:348(0.53%
used); numInnerClasses:2) ==
*(1) HashAggregate(keys=[key#xL], functions=[partial_max(value#xL)],
output=[key#xL, max#xL])
+- *(1) Project [id#xL AS key#xL, id#xL AS value#xL]
+- *(1) Range (0, 5, step=1, splits=2)
== Subtree 2 / 2 (maxMethodCodeSize:252; maxConstantPoolSize:214(0.33%
used); numInnerClasses:0) ==
*(2) HashAggregate(keys=[key#xL], functions=[max(value#xL)], output=[key#xL,
max(value)#xL])
+- AQEShuffleRead coalesced
+- ShuffleQueryStage 0
+- Exchange hashpartitioning(key#xL, 5), ENSURE_REQUIREMENTS,
[plan_id=55]
+- *(1) HashAggregate(keys=[key#xL],
functions=[partial_max(value#xL)], output=[key#xL, max#xL])
+- *(1) Project [id#xL AS key#xL, id#xL AS value#xL]
+- *(1) Range (0, 5, step=1, splits=2)
```
to:
```
Found 1 WholeStageCodegen subtrees.
== Subtree 1 / 1 (maxMethodCodeSize:308; maxConstantPoolSize:374(0.57%
used); numInnerClasses:2) ==
*(1) HashAggregate(keys=[key#xL], functions=[max(value#xL)], output=[key#xL,
max(value)#xL])
+- *(1) HashAggregate(keys=[key#xL], functions=[partial_max(value#xL)],
output=[key#xL, max#xL])
+- *(1) Project [id#xL AS key#xL, id#xL AS value#xL]
+- *(1) Range (0, 5, step=1, splits=2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
