sunchao commented on code in PR #37379:
URL: https://github.com/apache/spark/pull/37379#discussion_r935807307
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala:
##########
@@ -32,7 +32,7 @@ abstract class ParquetSchemaPruningSuite extends
SchemaPruningSuite with Adaptiv
override protected val vectorizedReaderEnabledKey: String =
SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key
override protected val vectorizedReaderNestedEnabledKey: String =
- SQLConf.ORC_VECTORIZED_READER_NESTED_COLUMN_ENABLED.key
+ SQLConf.PARQUET_VECTORIZED_READER_NESTED_COLUMN_ENABLED.key
Review Comment:
Oops, good catch!
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala:
##########
@@ -104,9 +107,7 @@ case class ParquetPartitionReaderFactory(
}
override def supportColumnarReads(partition: InputPartition): Boolean = {
- sqlConf.parquetVectorizedReaderEnabled && sqlConf.wholeStageEnabled &&
- resultSchema.length <= sqlConf.wholeStageMaxNumFields &&
- resultSchema.forall(_.dataType.isInstanceOf[AtomicType])
+ supportsColumnar
Review Comment:
should we just inline it here instead of declaring a private field
`supportsColumnar`? since it's only used in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
