Kimahriman commented on code in PR #37379:
URL: https://github.com/apache/spark/pull/37379#discussion_r935819326
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala:
##########
@@ -104,9 +107,7 @@ case class ParquetPartitionReaderFactory(
}
override def supportColumnarReads(partition: InputPartition): Boolean = {
- sqlConf.parquetVectorizedReaderEnabled && sqlConf.wholeStageEnabled &&
- resultSchema.length <= sqlConf.wholeStageMaxNumFields &&
- resultSchema.forall(_.dataType.isInstanceOf[AtomicType])
+ supportsColumnar
Review Comment:
Since this is called per partition, I figured it made since to make a
private field to calculate `!WholeStageCodegenExec.isTooManyFields(sqlConf,
resultSchema)` once instead of every partition, since this doesn't actually
depend on the partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
