Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/732#discussion_r12552796
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -90,7 +92,7 @@ class MLUtilsSuite extends FunSuite with
LocalSparkContext {
assert(multiclassPoints(1).label === -1.0)
assert(multiclassPoints(2).label === -1.0)
- deleteQuietly(tempDir)
+ Utils.deleteRecursively(tempDir)
--- End diff --
That's true. I suppose the idea is that tests shouldn't fail merely because
cleanup failed. But other tests that do cleanup don't swallow exceptions. I had
thought to both be consistent, and err on the side of reporting such an error
(in case it weirdly indicates a problem? like files being held open incorrectly
somewhere)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
