Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/732#discussion_r12553138
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -90,7 +92,7 @@ class MLUtilsSuite extends FunSuite with
LocalSparkContext {
assert(multiclassPoints(1).label === -1.0)
assert(multiclassPoints(2).label === -1.0)
- deleteQuietly(tempDir)
+ Utils.deleteRecursively(tempDir)
--- End diff --
Yeah, I don't quite see a reason why we'd want to squash these. Okay
perhaps we can standardize on "not squashing" exceptions and if it turns out
this is necessary here we can fix it up later. It does seem to be passing fine
in your patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
