beliefer commented on code in PR #37427:
URL: https://github.com/apache/spark/pull/37427#discussion_r940161522
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -1449,6 +1449,26 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
"PushedFilters: [NAME IS NOT NULL]"
checkPushedInfo(df5, expectedPlanFragment5)
checkAnswer(df5, Seq(Row(6, "jen", 12000, 1200, true)))
+
+ val df6 = sql("SELECT * FROM h2.test.employee WHERE " +
+ "bit_length(name) = 40")
Review Comment:
```suggestion
val df6 = sql("SELECT * FROM h2.test.employee WHERE bit_length(name) =
40")
```
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -1449,6 +1449,26 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
"PushedFilters: [NAME IS NOT NULL]"
checkPushedInfo(df5, expectedPlanFragment5)
checkAnswer(df5, Seq(Row(6, "jen", 12000, 1200, true)))
+
+ val df6 = sql("SELECT * FROM h2.test.employee WHERE " +
+ "bit_length(name) = 40")
+ checkFiltersRemoved(df6)
+ checkPushedInfo(df6, "[NAME IS NOT NULL, BIT_LENGTH(NAME) = 40]")
+ checkAnswer(df6, Seq(Row(1, "cathy", 9000, 1200, false),
+ Row(2, "david", 10000, 1300, true)))
+
+ val df7 = sql("SELECT * FROM h2.test.employee WHERE " +
+ "char_length(name) = 5")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
