cloud-fan commented on code in PR #37427:
URL: https://github.com/apache/spark/pull/37427#discussion_r941472084
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -217,6 +217,9 @@ class V2ExpressionBuilder(e: Expression, isPredicate:
Boolean = false) {
generateExpressionWithName("SUBSTRING", children)
case Upper(child) => generateExpressionWithName("UPPER", Seq(child))
case Lower(child) => generateExpressionWithName("LOWER", Seq(child))
+ case BitLength(child) => generateExpressionWithName("BIT_LENGTH",
Seq(child))
+ case Length(child) => generateExpressionWithName("CHAR_LENGTH", Seq(child))
Review Comment:
we should make sure the chid data type is string type, to safely translate
to `CHAR_LENGTH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
