srowen commented on code in PR #37408:
URL: https://github.com/apache/spark/pull/37408#discussion_r940401977
##########
python/pyspark/sql/types.py:
##########
@@ -815,6 +815,54 @@ def jsonValue(self) -> Dict[str, Any]:
@classmethod
def fromJson(cls, json: Dict[str, Any]) -> "StructType":
+ """
+ Constructs StructType from a scheme defined in json format
+
+ Parameters
+ ----------
+ json : Dict of str/any or a dict like object e.g. json object
Review Comment:
Dict -> dict, "dict like" -> dict-like. Maybe say a tiny bit more about what
dict of str/any is
##########
python/pyspark/sql/types.py:
##########
@@ -815,6 +815,54 @@ def jsonValue(self) -> Dict[str, Any]:
@classmethod
def fromJson(cls, json: Dict[str, Any]) -> "StructType":
+ """
+ Constructs StructType from a scheme defined in json format
Review Comment:
Nit: scheme -> schema, json -> JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
