srowen commented on code in PR #37408:
URL: https://github.com/apache/spark/pull/37408#discussion_r942444321
##########
python/pyspark/sql/types.py:
##########
@@ -815,6 +815,96 @@ def jsonValue(self) -> Dict[str, Any]:
@classmethod
def fromJson(cls, json: Dict[str, Any]) -> "StructType":
+ """
+ Constructs :class`StructType` from a schema defined in json format
Review Comment:
json -> JSON everywhere
##########
python/pyspark/sql/types.py:
##########
@@ -815,6 +815,96 @@ def jsonValue(self) -> Dict[str, Any]:
@classmethod
def fromJson(cls, json: Dict[str, Any]) -> "StructType":
+ """
+ Constructs :class`StructType` from a schema defined in json format
+
+ Parameters
+ ----------
+ json : dict or a dict-like object e.g. json object
Review Comment:
Clarify what json object means here. Object from what library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
