srielau commented on code in PR #37452:
URL: https://github.com/apache/spark/pull/37452#discussion_r942582684
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -71,6 +76,30 @@ trait SQLQueryTestHelper {
if (isSorted(df.queryExecution.analyzed)) (schema, answer) else (schema,
answer.sorted)
}
+ private def toJson(e: SparkThrowable): String = {
Review Comment:
I'm wondering whether we have messed up the order of the PRs here.
In my mental model I had us implement machineReadable Error message and then
simply "flip the config" to produce the golden files in that format. What we
have here now is a hand crafted JSON. Is that temporary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
