HyukjinKwon commented on code in PR #37724: URL: https://github.com/apache/spark/pull/37724#discussion_r958287277
########## python/docs/source/development/contributing.rst: ########## @@ -155,18 +155,13 @@ Now, you can start developing and `running the tests <testing.rst>`_. Contributing and Maintaining Type Hints ---------------------------------------- -PySpark type hints are provided using stub files, placed in the same directory as the annotated module, with exception to: - -* ``# type: ignore`` in modules which don't have their own stubs (tests, examples and non-public API). -* pandas API on Spark (``pyspark.pandas`` package) where the type hints are inlined. - -As a rule of thumb, only public API is annotated. +PySpark type hints are inlined, to take advantage of static type checking within the functions. Review Comment: I think we should keep "As a rule of thumb, only public API is annotated." I think it's not "within the functions" since it include parameters, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
