itholic commented on code in PR #37724: URL: https://github.com/apache/spark/pull/37724#discussion_r962436689
########## python/docs/source/development/contributing.rst: ########## @@ -189,9 +186,6 @@ Annotations should, when possible: * Be compatible with the current stable MyPy release. - -Complex supporting type definitions, should be placed in dedicated ``_typing.pyi`` stubs. See for example `pyspark.sql._typing.pyi <https://github.com/apache/spark/blob/master/python/pyspark/sql/_typing.pyi>`_. Review Comment: Yeah, this is intentionally removed since I think we better not to mention about the stub files (pyi) in the guide. Do you think it's good to keep this part as it is? (I have no strong opinion in either way, though) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
