MaxGekk commented on code in PR #37744: URL: https://github.com/apache/spark/pull/37744#discussion_r960982999
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ########## @@ -47,14 +47,23 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite with SQLHelper { assert(e.getMessage.contains(errorMessage)) } + def assertTypeMismatch(expr: Expression, errorMessage: String): Unit = { + val e = intercept[AnalysisException] { + assertSuccess(expr) + } + assert(e.getMessage.contains( + s"""Cannot resolve "${expr.sql}" due to data type mismatch:""")) + assert(e.getMessage.contains(errorMessage)) Review Comment: done ########## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ########## @@ -2666,10 +2666,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark val m = intercept[AnalysisException] { sql("SELECT * FROM t, S WHERE c = C") }.message - assert( - m.contains( - "cannot resolve '(spark_catalog.default.t.c = " + - "spark_catalog.default.S.C)' due to data type mismatch")) + assert(m.contains("""Cannot resolve "(c = C)" due to data type mismatch""")) Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org