MaxGekk commented on code in PR #37744:
URL: https://github.com/apache/spark/pull/37744#discussion_r961656263
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -75,6 +75,23 @@
"The value <str> (<fmt>) cannot be converted to <targetType> because it
is malformed. Correct the value as per the syntax, or change its format. Use
<suggestion> to tolerate malformed input and return NULL instead."
]
},
+ "DATATYPE_MISMATCH" : {
+ "message" : [
+ "Cannot resolve <sqlExpr> due to data type mismatch:"
+ ],
+ "subClass" : {
+ "BINARY_OP_DIFF_TYPES" : {
+ "message" : [
+ "the left and right arguments of the binary operator have different
types (<left> and <right>)."
+ ]
+ },
+ "BINARY_OP_WRONG_TYPE" : {
+ "message" : [
+ "the binary operator requires the input type <inputType>, not
<leftDataType>."
Review Comment:
I think you just introduce unnecessary assumptions between checks, and
confuse users. The error message says **precisely** that LEFT is operand has
wrong type. Users need to cast it or do something only with the LEFT one. When
you says ACTUAL, does the users have to check and/or fix both operands, or
left, or right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
