c27kwan opened a new pull request, #37771:
URL: https://github.com/apache/spark/pull/37771
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
There is no explicit `hashCode()` function override for the
`ArrayBasedMapData` LogicalPlan. As a result, there is a non-deterministic
error where the `hashCode()` computed for `ArrayBasedMapData` can be different
for two equal objects (objects with equal keys and values).
In this PR, we override the `hashCode` function so that it works exactly as
we expect. We also have an explicit `equals()` function for consistency with
how `Literal`s check for equality of `ArrayBasedMapData`.
### Why are the changes needed?
This is a bug fix for a non-deterministic error. It is also more consistent
with the rest of Spark if we implement the `hashCode` and `equals` methods
instead of relying on defaults.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
A simple unit test was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
