c27kwan commented on PR #37771: URL: https://github.com/apache/spark/pull/37771#issuecomment-1237905787
I've been going through old PRs and see that the `equals` and `hashCode` methods were actually purposely removed from this class: https://github.com/apache/spark/pull/13847 We've also chosen to honour this removal by adding the checks in other places like `Literal`: https://github.com/apache/spark/pull/30246 I also saw a newer PR (not merged) attempting to add these methods back in: https://github.com/apache/spark/pull/32552 Is this going to break an invariant if we now provide an equals and hashCode function only for ArrayBasedMapData? I'm going to make another variant of this PR and fix the `hashCode` only for `Literal` of `ArrayBasedMapData`, since that's the only place that's inconsistent right now between the `equals` and the `hashCode`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
