cloud-fan commented on code in PR #37749:
URL: https://github.com/apache/spark/pull/37749#discussion_r963255131
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -361,6 +361,18 @@ object KeyGroupedPartitioning {
partitionValues: Seq[InternalRow]): KeyGroupedPartitioning = {
KeyGroupedPartitioning(expressions, partitionValues.size,
Some(partitionValues))
}
+
+ def supportsExpressions(expressions: Seq[Expression]): Boolean = {
+ def isSupportedTransform(transform: TransformExpression): Boolean = {
+ transform.children.size == 1 &&
transform.children.head.isInstanceOf[AttributeReference]
+ }
+
+ expressions.forall {
+ case _: AttributeReference => true
Review Comment:
nested column in catalyst is not `AttributeReference`, but
`GetStructField(AttributeReference, ...)`. I think we need to support nested
column because we support v2 `NamedReference` before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
