peter-toth commented on PR #37824:
URL: https://github.com/apache/spark/pull/37824#issuecomment-1240770754
As we know that `BinaryComparison` needs (fully) canonicalized children to
get the right ordering of its children why don't we simply change
`BinaryComparison.preCanonicalized` to `BinaryComparison.canonicalized` and
modify it to use the canonicalized form of the nodes children:
```
abstract class BinaryComparison extends BinaryOperator with Predicate {
...
override lazy val canonicalized: Expression = {
withNewChildren(children.map(_.canonicalized)) match {
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
