ahshahid commented on code in PR #37824:
URL: https://github.com/apache/spark/pull/37824#discussion_r966173357
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala:
##########
@@ -65,6 +65,6 @@ object Canonicalize {
val newChildren = orderCommutative(l, { case Least(children) => children
})
Least(newChildren)
- case _ => e.withNewChildren(e.children.map(reorderCommutativeOperators))
+ case _ => e
Review Comment:
@attilapiros btw just realized that the case you mentioned as such is what
is being tested in the bug tests as GreaterThan , EqualTo etc are non
commutative expressions..
But I will use abs & also have a deeply nested expression tree containing a
mix of commutative & non commutative expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
