peter-toth opened a new pull request, #37851: URL: https://github.com/apache/spark/pull/37851
### What changes were proposed in this pull request? Move reorder of childen of `BinaryComparison`s to `canonicalized` phase. ### Why are the changes needed? https://github.com/apache/spark/pull/34883 improved expression canonicalization performance but introduced regression when a commutative operator is under a `BinaryComparison`. This is because children reorder by their hashcode can't happen in "preCanonicalized` phase when children are not "final". ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
