peter-toth commented on PR #37851:
URL: https://github.com/apache/spark/pull/37851#issuecomment-1242907318

   The benchmark:
   ```
     test("benchmark") {
       val col = Literal(true)
       var and = And(col, col)
       var i = 0
       while (i < 2000) {
         and = And(and, col)
         i += 1
       }
       and.canonicalized
     }
   ```
   is fine, 140ms on my machine. That's because we don't alter the bottom-up 
traversal, just at the `BinaryComparison` nodes we can swap the already ordered 
children.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to