ahshahid commented on PR #37824: URL: https://github.com/apache/spark/pull/37824#issuecomment-1242792830
> @ahshahid, please check #37851 as an anternative to this PR. It moves reorder of childen of `BinaryComparison`s to the 2nd phase. As reorder already happens bottom-up way in `Canonicalize. reorderCommutativeOperators `, this is just a small addition. I will go through it @peter-toth .. Will check perf impact.. if perf is maintained, then I agree its a simple & better fix.. The thing is Canonicalize. reorderCommutativeOperators only happens bottoms up if the commutative operators are of same type. In case it is nested "And" then the perf is obtained because only the top would call reorder.. with this, it will happen on each child & may have adverse impact on perf.. But again that is just my hypothesis , need to verify.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
