peter-toth commented on PR #37824: URL: https://github.com/apache/spark/pull/37824#issuecomment-1241638796
> > I think we could simply move the ordering logic from `BinaryComparison.preCanonicalized` to `Canonicalize.reorderCommutativeOperators` (and rename it to `reorderOperators`) and so keep the performance improvement of #34883. > > I suppose that will also work... thinking on it.. Actually I think it wont work., BinaryComparison to get correct results , needs hashCode of the operands, and the hashCode wiill not be correct , till canonicalize of the children is called, so it wont solve the issue... right? If we do all ordering in the 2nd pass then by the time we are ordering BinaryComparison's children its childrens have been fully canonicalized (ordered) so their hashcode will be correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
