ahshahid commented on PR #37851: URL: https://github.com/apache/spark/pull/37851#issuecomment-1244439173
I see that pre-canonicalized has been removed, which makes sense & is a single pass. This also caches the intermediate canonicalized expression which is a good thing in the sense it is doing with reorder.. It would have slightly detrimental impact on actual benchmark but well within tolerance. and since tree traversal has been removed from the reorder for non-commutative expressions which makes sense and improves perf. If all tests are passing it is good to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
