cloud-fan commented on code in PR #37969:
URL: https://github.com/apache/spark/pull/37969#discussion_r977763652
##########
core/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -178,9 +90,7 @@ private[spark] object SparkThrowableHelper {
val errorSubClass = e.getErrorSubClass
if (errorSubClass != null) g.writeStringField("errorSubClass",
errorSubClass)
if (format == STANDARD) {
- val errorInfo = errorClassToInfoMap.getOrElse(errorClass,
- throw SparkException.internalError(s"Cannot find the error class
'$errorClass'"))
- g.writeStringField("message", errorInfo.messageFormat)
+ g.writeStringField("message", e.getMessage)
Review Comment:
@MaxGekk I think this is a mistake. The STANDARD mode is a combine of PRETTY
and MINIMAL mode: it can get all the structured information, as well as the
original pretty message.
##########
core/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -178,9 +90,7 @@ private[spark] object SparkThrowableHelper {
val errorSubClass = e.getErrorSubClass
if (errorSubClass != null) g.writeStringField("errorSubClass",
errorSubClass)
if (format == STANDARD) {
- val errorInfo = errorClassToInfoMap.getOrElse(errorClass,
- throw SparkException.internalError(s"Cannot find the error class
'$errorClass'"))
- g.writeStringField("message", errorInfo.messageFormat)
+ g.writeStringField("message", e.getMessage)
Review Comment:
@MaxGekk I think this is a mistake. The STANDARD mode is a combination of
PRETTY and MINIMAL mode: it can get all the structured information, as well as
the original pretty message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
