cloud-fan commented on code in PR #37969:
URL: https://github.com/apache/spark/pull/37969#discussion_r978416368
##########
core/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -178,9 +90,7 @@ private[spark] object SparkThrowableHelper {
val errorSubClass = e.getErrorSubClass
if (errorSubClass != null) g.writeStringField("errorSubClass",
errorSubClass)
if (format == STANDARD) {
- val errorInfo = errorClassToInfoMap.getOrElse(errorClass,
- throw SparkException.internalError(s"Cannot find the error class
'$errorClass'"))
- g.writeStringField("message", errorInfo.messageFormat)
+ g.writeStringField("message", e.getMessage)
Review Comment:
Makes sense, we should allow the caller side to do substitution as they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]