MaxGekk commented on code in PR #37969:
URL: https://github.com/apache/spark/pull/37969#discussion_r978508477
##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -321,4 +323,22 @@ class SparkThrowableSuite extends SparkFunSuite {
| }
|}""".stripMargin)
}
+
+ test("overwrite error classes") {
+ withTempDir { dir =>
+ val json = new File(dir, "errors.json")
+ FileUtils.writeStringToFile(json,
+ """
+ |{
+ | "DIVIDE_BY_ZERO" : {
+ | "message" : [
+ | "abc"
+ | ]
+ | }
+ |}
+ |""".stripMargin)
+ val reader = new
ErrorClassesJsonReader(Seq(errorJsonFilePath.toUri.toURL, json.toURL))
Review Comment:
Do you use the existing JSON file? How can you guarantee that one JSON
overrides the standard one? Maybe you will add small one for testing to check
that it overrides error-classes.json?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
