dongjoon-hyun commented on code in PR #38084:
URL: https://github.com/apache/spark/pull/38084#discussion_r989714199
##########
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala:
##########
@@ -17,12 +17,19 @@
package org.apache.spark.deploy
+import java.net.InetAddress
+
import org.apache.hadoop.conf.Configuration
import org.apache.spark.{SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config.BUFFER_SIZE
class SparkHadoopUtilSuite extends SparkFunSuite {
+ private val setToDefaultValues = "Set by Spark to default values"
+ private val hadoopPropagation = "Set by Spark from keys starting with
'spark.hadoop'"
+ private val hivePropagation = "Set by Spark from keys starting with
'spark.hive'"
Review Comment:
We can remove these by
https://github.com/apache/spark/pull/38084/files#r989713735.
##########
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala:
##########
@@ -17,12 +17,19 @@
package org.apache.spark.deploy
+import java.net.InetAddress
+
import org.apache.hadoop.conf.Configuration
import org.apache.spark.{SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config.BUFFER_SIZE
class SparkHadoopUtilSuite extends SparkFunSuite {
+ private val setToDefaultValues = "Set by Spark to default values"
+ private val hadoopPropagation = "Set by Spark from keys starting with
'spark.hadoop'"
+ private val hivePropagation = "Set by Spark from keys starting with
'spark.hive'"
Review Comment:
We can remove these string duplications by
https://github.com/apache/spark/pull/38084/files#r989713735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
