dongjoon-hyun commented on code in PR #38084:
URL: https://github.com/apache/spark/pull/38084#discussion_r989716752
##########
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala:
##########
@@ -93,4 +139,41 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
assert(hadoopConf.get(key) === expected,
s"Mismatch in expected value of $key")
}
+
+ /**
+ * Assert that a hadoop configuration option has the expected value
+ * and has the expected source.
+ *
+ * @param hadoopConf configuration to query
+ * @param key key to look up
+ * @param expected expected value.
+ * @param expectedSource string required to be in the property source string
+ */
+ private def assertConfigMatches(
+ hadoopConf: Configuration,
+ key: String,
+ expected: String,
+ expectedSource: String): Unit = {
+ assertConfigValue(hadoopConf, key, expected)
+ assertConfigSourceContains(hadoopConf, key, expectedSource)
+ }
+
+ /**
+ * Assert that a source of a configuration matches a specific string.
+ * @param hadoopConf hadoop configuration
+ * @param key key to probe
+ * @param expectedSource expected source
+ */
+ private def assertConfigSourceContains(
+ hadoopConf: Configuration,
+ key: String,
+ expectedSource: String): Unit = {
Review Comment:
ditto. Indentation. Two more spaces for parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
