dongjoon-hyun commented on code in PR #38084:
URL: https://github.com/apache/spark/pull/38084#discussion_r990384704
##########
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala:
##########
@@ -32,9 +36,12 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
val hadoopConf = new Configuration(false)
sc.set("spark.hadoop.orc.filterPushdown", "true")
new SparkHadoopUtil().appendSparkHadoopConfigs(sc, hadoopConf)
- assertConfigValue(hadoopConf, "orc.filterPushdown", "true" )
- assertConfigValue(hadoopConf, "fs.s3a.downgrade.syncable.exceptions",
"true")
- assertConfigValue(hadoopConf, "fs.s3a.endpoint", "s3.amazonaws.com")
+ assertConfigMatches(hadoopConf, "orc.filterPushdown", "true",
+ SOURCE_SPARK_HADOOP)
Review Comment:
Do we need to split the line? Otherwise, please make it as a single line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
