amaliujia commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r990689327
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -107,15 +107,17 @@ message Join {
}
}
-// Relation of type [[Union]], at least one input must be set.
Review Comment:
This documentation (`at least one input must be set`) does not match the
implementation `assert(u.getInputsCount == 2, "Union must have 2 inputs")`. To
avoid confusion I choose to remove this for now.
Once our implementation is stable, we can go back to re-document the
semantic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
