grundprinzip commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r990759375
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -107,15 +107,17 @@ message Join {
}
}
-// Relation of type [[Union]], at least one input must be set.
Review Comment:
TBH i think the comment was not correct in the first place. I mean while a
set can have one element, the question is does it make sense to have a set plan
with only one?
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -35,7 +35,7 @@ message Relation {
Project project = 3;
Filter filter = 4;
Join join = 5;
- Union union = 6;
Review Comment:
Why is Set better than Union? Just from a SQL naming persepective, Union
might be what users are used to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
