cloud-fan commented on code in PR #38180:
URL: https://github.com/apache/spark/pull/38180#discussion_r990898535
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala:
##########
@@ -237,7 +237,7 @@ case class CreateDataSourceTableAsSelectCommand(
className = table.provider.get,
partitionColumns = table.partitionColumnNames,
bucketSpec = table.bucketSpec,
- options = table.storage.properties ++ pathOption,
+ options = table.properties ++ table.storage.properties ++ pathOption,
Review Comment:
I think the PR title is a bit misleading. We do respect TBLPROPERTIES in
CTAS, but we do not include them as DS v1 write options, which should be
specified by OPTIONS, or SERDEPROPERTIES.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
