cloud-fan commented on code in PR #38180:
URL: https://github.com/apache/spark/pull/38180#discussion_r990898884


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -230,6 +230,16 @@ class InMemoryCatalogedDDLSuite extends DDLSuite with 
SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-40719: CTAS should respect TBLPROPERTIES during query 
execution") {
+    withTable("t") {
+      withTempDir { dir =>
+        sql(s"CREATE TABLE t USING PARQUET LOCATION '$dir' " +
+          "TBLPROPERTIES (parquet.compression 'zstd') AS SELECT 1")

Review Comment:
   I agree that it's better to be consistent between the Spark native CREATE 
TABLE syntax and the Hive one, but we probably should revisit the Hive syntax 
first. If it's reasonable (treat TBLPROPERTIES as write options), we can follow 
it in the native syntax



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to