LuciferYang commented on code in PR #38162:
URL: https://github.com/apache/spark/pull/38162#discussion_r990919237
##########
project/SparkBuild.scala:
##########
@@ -655,19 +655,47 @@ object SparkConnect {
(assembly / logLevel) := Level.Info,
+ // Exclude `scala-library` from assembly.
+ (assembly / assemblyPackageScala / assembleArtifact) := false,
+
+ // Exclude `pmml-model-*.jar`,
`scala-collection-compat_*.jar`,`jsr305-*.jar` and
+ // `unused-1.0.0.jar` from assembly.
+ (assembly / assemblyExcludedJars) := {
+ val cp = (assembly / fullClasspath).value
+ cp filter { v =>
+ val name = v.data.getName
+ name.startsWith("pmml-model-") ||
name.startsWith("scala-collection-compat_") ||
+ name.startsWith("jsr305-") || name == "unused-1.0.0.jar"
+ }
+ },
+
(assembly / assemblyShadeRules) := Seq(
ShadeRule.rename("io.grpc.**" ->
"org.sparkproject.connect.grpc.@0").inAll,
ShadeRule.rename("com.google.common.**" ->
"org.sparkproject.connect.guava.@1").inAll,
ShadeRule.rename("com.google.thirdparty.**" ->
"org.sparkproject.connect.guava.@1").inAll,
ShadeRule.rename("com.google.protobuf.**" ->
"org.sparkproject.connect.protobuf.@1").inAll,
+ ShadeRule.rename("android.annotation.**" ->
"org.sparkproject.connect.android_annotation.@1").inAll,
Review Comment:
No, I think we should follow the existing rules, `spark.shade.packageName`
defined as `org.sparkproject` on May 8, 2019. If we need to change this rule,
it is better to change it uniformly by an independent pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
